mirror of
https://gitea.com/gitea/runner.git
synced 2026-08-28 06:47:45 +00:00
12dc9d26a2
Fixes 51 bugs discovered via comparison with `actions/runner`. Every fix has test coverage.
### Secrets
- A short secret registered no shifted-base64 form, so `base64("user:$TOKEN")` printed in the clear
- Encoded forms came only from the whole trimmed value, missing padded and per-line spellings
- Masks split only on `\n`, so `::add-mask::a%0Db` registered neither half
- Adds XML, expression-string and quote-trimming encoders
### Workflow commands
- Split at the last `::` or `]` rather than the first, so `::add-mask::a::b` registered no mask
- A command on the last line without a newline was ignored, and `::ADD-MASK::` did nothing
- `##[...]` did not decode `%3B`/`%5D`, properties lost anything after a second `=`
- `$GITHUB_ENV` and `::set-env::` now refuse `NODE_OPTIONS`
### Status
- `continue-on-error` reported failed, a cancelled job reported success, an `if:` error reported cancelled
- File commands ran after `continue-on-error`, failing the job while the step stayed green
- A bad job output aborted the whole run instead of that job
### Steps and actions
- `${{ matrix.* }}` and `${{ strategy.* }}` were empty inside composite actions
- Composite inputs leaked into nested actions as `INPUT_*`, `with:` matched case-sensitively, `pre` failures were dropped
- Docker actions dropped `runs.env` when the caller passed `with: args:`, and caller `args`/`entrypoint` beat the manifest
- An implicit shell ran with `pipefail`, a `shell:` without `{0}` passed without running
- `container.env` overrode job env and every `$GITHUB_ENV` write, heredocs lost leading blank lines, `$GITHUB_PATH` was not BOM-decoded
Written by Claude Opus 5.
Reviewed-on: https://gitea.com/gitea/runner/pulls/1194
Reviewed-by: bircni <bircni@icloud.com>
Co-authored-by: silverwind <me@silverwind.io>
115 lines
3.8 KiB
Go
115 lines
3.8 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package runner
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"gitea.com/gitea/runner/act/common"
|
|
"gitea.com/gitea/runner/act/common/git"
|
|
|
|
"gitea.dev/actionslib/pkg/model"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestCompositeActionParity(t *testing.T) {
|
|
t.Run("inherits contexts without leaking inputs", func(t *testing.T) {
|
|
ctx := t.Context()
|
|
strategy := &model.Strategy{MaxParallel: 3}
|
|
parent := &RunContext{
|
|
Config: &Config{},
|
|
Matrix: map[string]any{"os": "linux"},
|
|
Run: &model.Run{JobID: "job", Workflow: &model.Workflow{Name: "workflow", Jobs: map[string]*model.Job{"job": {Strategy: strategy}}}},
|
|
JobContainer: &jobContainerMock{},
|
|
}
|
|
composite := newCompositeRunContext(ctx, parent, &stepActionRemote{
|
|
Step: &model.Step{With: map[string]string{"SHARED": "outer"}},
|
|
RunContext: parent,
|
|
action: &model.Action{Inputs: map[string]model.Input{"shared": {Default: "outer-default"}}},
|
|
env: map[string]string{"INPUT_SHARED": "outer"},
|
|
}, "/action")
|
|
|
|
assert.Same(t, strategy, composite.Run.Job().Strategy)
|
|
assert.Equal(t, "linux|3|outer", composite.NewExpressionEvaluator(ctx).Interpolate(ctx,
|
|
"${{ matrix.os }}|${{ strategy.max-parallel }}|${{ inputs.shared }}"))
|
|
assert.NotContains(t, composite.Env, "INPUT_SHARED")
|
|
|
|
nestedEnv := composite.GetEnv()
|
|
populateEnvsFromInput(ctx, &nestedEnv, &model.Action{Inputs: map[string]model.Input{"shared": {Default: "inner-default"}}}, composite)
|
|
assert.Equal(t, "inner-default", nestedEnv["INPUT_SHARED"])
|
|
})
|
|
|
|
t.Run("propagates pre failures", func(t *testing.T) {
|
|
setCloneExecutor(t, func(git.NewGitCloneExecutorInput) common.Executor { return common.NewErrorExecutor(assert.AnError) })
|
|
rc := &RunContext{
|
|
Config: &Config{GitHubInstance: "github.com", ActionCacheDir: t.TempDir()},
|
|
Run: &model.Run{JobID: "job", Workflow: &model.Workflow{Jobs: map[string]*model.Job{"job": {}}}},
|
|
JobContainer: &jobContainerMock{},
|
|
}
|
|
|
|
require.ErrorIs(t, rc.compositeExecutor(&model.Action{Runs: model.ActionRuns{Using: "composite", Steps: []model.Step{{ID: "nested", Uses: "org/action@v1"}}}}).pre(t.Context()), assert.AnError)
|
|
})
|
|
}
|
|
|
|
func TestAppendUniqueMasks(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
dst []string
|
|
src []string
|
|
want []string
|
|
}{
|
|
{
|
|
name: "appends new masks",
|
|
dst: []string{"a"},
|
|
src: []string{"b", "c"},
|
|
want: []string{"a", "b", "c"},
|
|
},
|
|
{
|
|
name: "skips masks already present",
|
|
dst: []string{"a", "b"},
|
|
src: []string{"a", "b"},
|
|
want: []string{"a", "b"},
|
|
},
|
|
{
|
|
name: "deduplicates within src",
|
|
dst: []string{"a"},
|
|
src: []string{"b", "b", "a"},
|
|
want: []string{"a", "b"},
|
|
},
|
|
{
|
|
name: "empty src leaves dst unchanged",
|
|
dst: []string{"a"},
|
|
src: nil,
|
|
want: []string{"a"},
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
assert.Equal(t, tt.want, appendUniqueMasks(tt.dst, tt.src))
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestAppendUniqueMasksNoExponentialGrowth reproduces the exponential growth of
|
|
// the parent's Masks slice observed with nested/repeated composite actions. A
|
|
// composite RunContext is seeded with its parent's masks and the whole seeded
|
|
// slice was previously appended back into the parent, doubling its length on
|
|
// every composite action.
|
|
func TestAppendUniqueMasksNoExponentialGrowth(t *testing.T) {
|
|
parentMasks := []string{"secret"}
|
|
|
|
for range 20 {
|
|
// compositeRC.Masks starts as a copy of the parent's masks (it is
|
|
// seeded with parent.Masks in newCompositeRunContext).
|
|
compositeMasks := make([]string, len(parentMasks))
|
|
copy(compositeMasks, parentMasks)
|
|
|
|
parentMasks = appendUniqueMasks(parentMasks, compositeMasks)
|
|
}
|
|
|
|
assert.Equal(t, []string{"secret"}, parentMasks)
|
|
}
|