Fix GCC 15 -Wdangling-pointer

Telegram/SourceFiles/boxes/peers/edit_peer_info_box.cpp

@@ -2285,11 +2285,13 @@ void Controller::saveUsernamesOrder() {
 		_api.request(MTPchannels_DeactivateAllUsernames(
 			channel->inputChannel()
 		)).done([=] {
-			channel->setUsernames(channel->editableUsername().isEmpty()
+			if (channel->editableUsername().isEmpty()) {
-				? Data::Usernames()
+				channel->setUsernames({});
-				: Data::Usernames{
+			} else {
+				channel->setUsernames({
 					{ channel->editableUsername(), true, true }
 				});
+			}
 			continueSave();
 		}).send();
 	} else {

Telegram/SourceFiles/data/data_session.cpp

@@ -748,12 +748,14 @@ not_null<UserData*> Session::processUser(const MTPUser &data) {
 			status = data.vstatus();
 			if (!minimal) {
 				const auto newUsername = uname;
-				const auto newUsernames = data.vusernames()
+				if (data.vusernames()) {
-					? Api::Usernames::FromTL(*data.vusernames())
+					result->setUsernames(
-					: !newUsername.isEmpty()
+						Api::Usernames::FromTL(*data.vusernames()));
-					? Data::Usernames{{ newUsername, true, true }}
+				} else if (!newUsername.isEmpty()) {
-					: Data::Usernames();
+					result->setUsernames({{ newUsername, true, true }});
-				result->setUsernames(newUsernames);
+				} else {
+					result->setUsernames({});
+				}
 			}
 		}
 		if (const auto &status = data.vemoji_status()) {
@@ -957,15 +959,17 @@ not_null<PeerData*> Session::processChat(const MTPChat &data) {
 
 		{
 			const auto newUsername = qs(data.vusername().value_or_empty());
-			const auto newUsernames = data.vusernames()
-				? Api::Usernames::FromTL(*data.vusernames())
-				: !newUsername.isEmpty()
-				? Data::Usernames{ Data::Username{ newUsername, true, true } }
-				: Data::Usernames();
 			channel->setName(
 				qs(data.vtitle()),
 				TextUtilities::SingleLine(newUsername));
-			channel->setUsernames(newUsernames);
+			if (data.vusernames()) {
+				channel->setUsernames(
+					Api::Usernames::FromTL(*data.vusernames()));
+			} else if (!newUsername.isEmpty()) {
+				channel->setUsernames({ { newUsername, true, true } });
+			} else {
+				channel->setUsernames({});
+			}
 		}
 		const auto hasUsername = !channel->username().isEmpty();
 

Telegram/SourceFiles/iv/iv_prepare.cpp

@@ -460,9 +460,13 @@ QByteArray Parser::block(const MTPDpageBlockList &data) {
 
 QByteArray Parser::block(const MTPDpageBlockBlockquote &data) {
 	const auto caption = rich(data.vcaption());
-	const auto cite = caption.isEmpty()
+	const auto cite = [&] {
-		? QByteArray()
+		if (caption.isEmpty()) {
-		: tag("cite", { { "dir", "auto" } }, caption);
+			return QByteArray();
+		} else {
+			return tag("cite", { { "dir", "auto" } }, caption);
+		}
+	}();
 	return tag("blockquote", {
 		{ "dir", "auto" }
 	}, rich(data.vtext()) + cite);
@@ -470,9 +474,13 @@ QByteArray Parser::block(const MTPDpageBlockBlockquote &data) {
 
 QByteArray Parser::block(const MTPDpageBlockPullquote &data) {
 	const auto caption = rich(data.vcaption());
-	const auto cite = caption.isEmpty()
+	const auto cite = [&] {
-		? QByteArray()
+		if (caption.isEmpty()) {
-		: tag("cite", { { "dir", "auto" } }, caption);
+			return QByteArray();
+		} else {
+			return tag("cite", { { "dir", "auto" } }, caption);
+		}
+	}();
 	return tag("div", {
 		{ "class", "pullquote" },
 		{ "dir", "auto" },
@@ -1084,12 +1092,14 @@ QByteArray Parser::rich(const MTPRichText &text) {
 	}, [&](const MTPDtextAnchor &data) {
 		const auto inner = rich(data.vtext());
 		const auto name = utf(data.vname());
-		return inner.isEmpty()
+		if (inner.isEmpty()) {
-			? tag("a", { { "name", name } })
+			return tag("a", { { "name", name } });
-			: tag(
+		} else {
+			return tag(
 				"span",
 				{ { "class", "reference" } },
 				tag("a", { { "name", name } }) + inner);
+		}
 	});
 }